I am not a big fan of top tens but 10 Tips for Better Pull Requests is well worth reading.
Join the mailing list or subscribe to the RSS feed. Follow me on Mastodon or X.
A good Pull Request involves more than just some code. In most cases, there’s one or more reviewer(s) involved, who will have to review your Pull Request in order to evaluate whether it’s a good fit for inclusion in the code base. Not only must you produce good code, but you must also cater to the person(s) doing the review.
Here’s a list of tips to make your Pull Request better. It isn’t exhaustive, but I think it addresses some of the more important aspects of creating a good Pull Request.